Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IP and Hostname trusted addresses #2619

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

sjberman
Copy link
Contributor

Problem: Our initial implementation of rewriting client IP only supported CIDRs for the trusted addresses field.

Solution: Add support for IP addresses and hostnames

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@sjberman sjberman requested review from a team as code owners September 27, 2024 18:23
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart labels Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (d6a478d) to head (48590d4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2619   +/-   ##
=======================================
  Coverage   88.61%   88.62%           
=======================================
  Files         105      105           
  Lines        8110     8116    +6     
  Branches       50       50           
=======================================
+ Hits         7187     7193    +6     
  Misses        866      866           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc update LGTM but PR is primarily code so I will but add an approval.

Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Problem: Our initial implementation of rewriting client IP only supported CIDRs for the trusted addresses field.

Solution: Add support for IP addresses and hostnames
@sjberman sjberman enabled auto-merge (squash) September 30, 2024 20:54
@sjberman sjberman merged commit f24cca7 into nginxinc:main Sep 30, 2024
47 checks passed
@sjberman sjberman deleted the enh/ip-addr-trust branch September 30, 2024 21:19
salonichf5 pushed a commit that referenced this pull request Oct 8, 2024
Problem: Our initial implementation of rewriting client IP only supported CIDRs for the trusted addresses field.

Solution: Add support for IP addresses and hostnames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request helm-chart Relates to helm chart
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants