-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support IP and Hostname trusted addresses #2619
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2619 +/- ##
=======================================
Coverage 88.61% 88.62%
=======================================
Files 105 105
Lines 8110 8116 +6
Branches 50 50
=======================================
+ Hits 7187 7193 +6
Misses 866 866
Partials 57 57 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc update LGTM but PR is primarily code so I will but add an approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Problem: Our initial implementation of rewriting client IP only supported CIDRs for the trusted addresses field. Solution: Add support for IP addresses and hostnames
aef57a2
to
48590d4
Compare
Problem: Our initial implementation of rewriting client IP only supported CIDRs for the trusted addresses field. Solution: Add support for IP addresses and hostnames
Problem: Our initial implementation of rewriting client IP only supported CIDRs for the trusted addresses field.
Solution: Add support for IP addresses and hostnames
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.