Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate default http server in NGINX if http listener exists in Gateway #320

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

kate-osborn
Copy link
Contributor

Problem: NKG does not generate an nginx server for an HTTP listener with no routes.

Fix: If an HTTP or HTTPS listener exists, we will generate an nginx default HTTP or SSL server block.

Fixes #316

@kate-osborn kate-osborn merged commit 6762a95 into main Dec 13, 2022
@kate-osborn kate-osborn deleted the http-listener-no-routes branch December 13, 2022 16:40
@pleshakov pleshakov added the bug Something isn't working label Apr 21, 2023
@pleshakov pleshakov changed the title Generate default http server if http listener exists Generate default http server in NGINX if http listener exists in Gateway Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

NGINX Kubernetes Gateway doesn't generate an NGINX server for an HTTP listener with 0 routes
2 participants