Set Accepted condition type on Gateway status #633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #368
Sets Accepted condition type on Gateway status. Accepted can be
true/false
and the following reasons are used:ListenersNotValid
,Invalid
,GatewayConflict
, andAccepted
.The
Invalid
reason is used when the GatewayClass for the Gateway is missing or invalid. In this case, both the Gateway and all its listeners are considered invalid. No additional validation is performed for the listeners. The Gateway and its listeners will have the conditionAccepted/false/Invalid
set on their statuses.This PR also replaces the
ListenerUnsupportedAddress
Condition reason with theListenerUnsupportedValue
reason to be consistent with the rest of our unsupported fields.