Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor controllers registration #646

Merged
merged 2 commits into from
May 17, 2023
Merged

Refactor controllers registration #646

merged 2 commits into from
May 17, 2023

Conversation

pleshakov
Copy link
Contributor

  • Move unexported controller registration function and types from internal/manager to internal/reconciler package and make them exported. This will allow us to reuse them in packages other than manager.
  • Rename reconciler package to controller to better reflect the purpose of the package.

This is needed #634 . A related part of the code from the provisioner prototype -- https://github.com/nginxinc/nginx-kubernetes-gateway/pull/629/files#r1187732046

@pleshakov
Refactor controllers registration
2896aef 
- Move unexported controller registration function and types from
internal/manager to internal/reconciler package and make them exported.
This will allow us to reuse them in packages other than manager.
- Rename reconciler package to controller to better reflect the purpose
of the package.
@pleshakov pleshakov requested a review from a team as a code owner May 17, 2023 14:20
@github-actions github-actions bot added the tech-debt Short-term pain, long-term benefit label May 17, 2023
@pleshakov pleshakov mentioned this pull request May 17, 2023
Closed
kate-osborn
kate-osborn approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pleshakov pleshakov merged commit 486bed0 into main May 17, 2023
@pleshakov pleshakov deleted the techdebt/refactor-controllers branch May 17, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman left review comments

@kate-osborn kate-osborn kate-osborn approved these changes

Assignees
No one assigned
Labels
tech-debt Short-term pain, long-term benefit
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pleshakov @sjberman @kate-osborn