Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update route condition where listener is not found #675

Merged
merged 1 commit into from
May 25, 2023

Conversation

ciarams87
Copy link
Member

Proposed changes

Report Accepted(false), Reason NoMatchingParent, in the status of HTTPRoute when the section name (listener) in the Gateway is not found.

Closes #306

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@ciarams87 ciarams87 requested a review from a team as a code owner May 24, 2023 11:53
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels May 24, 2023
@ciarams87 ciarams87 force-pushed the feat/update-route-conditions branch from f21e73e to 4e6927a Compare May 25, 2023 08:38
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ciarams87 ciarams87 force-pushed the feat/update-route-conditions branch from 4e6927a to 8b900ae Compare May 25, 2023 16:01
@ciarams87 ciarams87 merged commit 046496f into nginxinc:main May 25, 2023
@ciarams87 ciarams87 deleted the feat/update-route-conditions branch May 25, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Core API: Report proper conditions for HTTPRoute attachment edge cases
4 participants