Ensure Prefix matching requires trailing slash #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
suggested changes
Jul 6, 2023
sjberman
force-pushed
the
bug/prefix-matching
branch
from
df10c5c
to
1e9c7aa
Compare
sjberman
force-pushed
the
bug/prefix-matching
branch
from
1e9c7aa
to
2775152
Compare
pleshakov
suggested changes
Jul 10, 2023
sjberman
force-pushed
the
bug/prefix-matching
branch
from
2775152
to
9903d57
Compare
|
Now that all conformance tests pass, I can remove |
pleshakov
reviewed
Jul 11, 2023
There was a problem hiding this comment.
a few comments/suggestions based on the new code. looks good otherwise
Now that all conformance tests pass, I can remove continue-on-error if we want. That way we can actually get visibility into the tests from the PR page.
👍 ,
for tracking/auditing purposes, could we merge it in a separate commit? also, it will help to simplify reverting it in case we need to
Problem: When using a prefix path match, a path such as /foobar would match for the prefix /foo, which should not happen. Prefixes need a "/" delimiter between path segments. Solution: In order to allow just the prefix without a trailing slash, as well as more path segments using a slash delimiter, we now create two location blocks. One uses exact matching for the configured prefix path, and the other uses prefix matching with a trailing slash.
sjberman
force-pushed
the
bug/prefix-matching
branch
from
9903d57
to
e7a3213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When using a prefix path match, a path such as /foobar would match for the prefix /foo, which should not happen. Prefixes need a "/" delimiter between path segments.
Solution: In order to allow just the prefix without a trailing slash, as well as more path segments using a slash delimiter, we now create two location blocks. One uses exact matching for the configured prefix path, and the other uses prefix matching with a trailing slash.
Testing: Conformance test now passes
Closes #796