Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced routing guide #993

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

sjberman
Copy link
Contributor

Problem: As a potential user of NKG
I want a guide to help me understand how I can direct traffic to my set of applications, utilizing different paths, http verbs, and hostnames, headers, and query parameters. So that I can easily understand how to immediately start using NKG in my environment.

Solution: Add a guide describing how to configure more advanced HTTPRoutes using various parameters.

Testing: Ran through the guide

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #877

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 21, 2023
examples/advanced-routing/README.md Outdated Show resolved Hide resolved
docs/guides/advanced-routing.md Outdated Show resolved Hide resolved
docs/guides/advanced-routing.md Outdated Show resolved Hide resolved
docs/guides/advanced-routing.md Show resolved Hide resolved
docs/guides/advanced-routing.md Outdated Show resolved Hide resolved
docs/guides/advanced-routing.md Outdated Show resolved Hide resolved
docs/guides/advanced-routing.md Outdated Show resolved Hide resolved
docs/guides/advanced-routing.md Outdated Show resolved Hide resolved
docs/guides/advanced-routing.md Outdated Show resolved Hide resolved
docs/guides/advanced-routing.md Show resolved Hide resolved
docs/guides/advanced-routing.md Outdated Show resolved Hide resolved
@sjberman sjberman marked this pull request as ready for review August 23, 2023 15:35
@sjberman sjberman requested a review from a team as a code owner August 23, 2023 15:35
@brianehlert
Copy link

"Advanced HTTP Routing" as a title is vague and not discoverable.
A customer is ever going to search using the title. And for discoverability the title should hint at the use cases.

Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@sjberman
Copy link
Contributor Author

@brianehlert What about "Routing to applications using HTTP matching conditions"?

Copy link
Contributor

@kate-osborn kate-osborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Problem: As a potential user of NKG
I want a guide to help me understand how I can direct traffic to my set of applications, utilizing different paths, http verbs, and hostnames, headers, and query parameters.
So that I can easily understand how to immediately start using NKG in my environment.

Solution: Add a guide describing how to configure more advanced HTTPRoutes using various parameters.
@sjberman sjberman merged commit f71b6a0 into nginxinc:main Aug 28, 2023
21 checks passed
@sjberman sjberman deleted the docs/use-case-877 branch August 28, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use Case Guide: Direct traffic to multiple applications using different paths and hostnames
7 participants