Skip to content

Conversation

lamATnginx
Copy link
Collaborator

@lamATnginx lamATnginx commented Jul 28, 2025

Proposed changes

To better handle closing tags on card shortcode such as {{<card ... />}}, the following need to be changed -

  • Fix whitespace issues resulting in the following when rendered:
    Screenshot 2025-07-28 at 3 22 27 PM

  • Better handle case where there is no .Inner due to the closing tag. This results in more centered header as seen below:

    Before:
    Screenshot 2025-07-28 at 3 26 43 PM

    After:
    Screenshot 2025-07-28 at 3 26 26 PM

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this Jul 28, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner July 28, 2025 22:10
@lamATnginx lamATnginx added the enhancement New feature or request label Jul 28, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/336/

@nginx-jack nginx-jack merged commit a8d8b5c into mainframe Jul 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants