Skip to content

Pin dependency versions in workflows #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2025
Merged

Pin dependency versions in workflows #405

merged 2 commits into from
Sep 23, 2025

Conversation

lamATnginx
Copy link
Collaborator

Proposed changes

Pinning dependency versions in workflows.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@lamATnginx lamATnginx self-assigned this Sep 23, 2025
@lamATnginx lamATnginx requested a review from a team as a code owner September 23, 2025 16:42
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-hugo-theme/405/

@lamATnginx
Copy link
Collaborator Author

Versions were chosen based on their changelogs and if they solved some notable issue (e.g. security, critical bug fix) for the dependency.

danielledeleo
danielledeleo approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@danielledeleo danielledeleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but make sure Dependabot is running correctly

TasoOneAsia
TasoOneAsia approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@TasoOneAsia TasoOneAsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't verify exact SHAs but LGTM

@lamATnginx lamATnginx merged commit e5c56e3 into main Sep 23, 2025
6 checks passed
@lamATnginx lamATnginx deleted the workflow-dep-version-pin branch September 23, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielledeleo danielledeleo danielledeleo approved these changes

@TasoOneAsia TasoOneAsia TasoOneAsia approved these changes

Assignees

@lamATnginx lamATnginx

Labels
security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lamATnginx @danielledeleo @TasoOneAsia