This repository was archived by the owner on May 24, 2023. It is now read-only.
Add IngressLink support #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleshakov
reviewed
Feb 12, 2021
Contributor
pleshakov
left a comment
pleshakov
left a comment
There was a problem hiding this comment.
Please see my comments
Dean-Coakley
force-pushed
the
feat/kic-110-ingressLink
branch
from
6b8e5b3 to
c7af792
Compare
pleshakov
approved these changes
Feb 16, 2021
Contributor
pleshakov
left a comment
pleshakov
left a comment
There was a problem hiding this comment.
Lgtm! with a few minor doc issues
lucacome
approved these changes
Feb 18, 2021
Dean-Coakley
force-pushed
the
feat/kic-110-ingressLink
branch
from
55c51b9 to
872aa43
Compare
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
controller.extraLabelsfrom here as required for IngressLink to function.Checklist
Before creating a PR, run through this checklist and mark each as complete.