Skip to content
This repository was archived by the owner on Aug 22, 2025. It is now read-only.

Conversation

abdennour
Copy link
Contributor

@abdennour abdennour commented Dec 12, 2023

Still hardcoding namespace because the application cannot use another namespaces . it resolves #158

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue using one of the supported keywords here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

Still hardcoding namespace because the application cannot use another
namespaces . it resolves nginxinc#158
@abdennour
Copy link
Contributor Author

it solves #158

@ciroque
Copy link
Collaborator

ciroque commented Dec 14, 2023

Hello @abdennour ,

Thanks for this contribution! I will take a run through this change tomorrow and complete my review. On the surface it looks good, just need to run it into a Cluster and ensure I understand it better.

Thanks again!

@abdennour
Copy link
Contributor Author

Hello @ciroque , thanks for quick & positive response to PR

Copy link
Collaborator

@ciroque ciroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abdennour , I just ran this change into our test k8s cluster and everything looks good. Going to rebase and merge momentarily.

Thanks again for your contribution!

@ciroque ciroque merged commit 24ea3e7 into nginxinc:main Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs in Helm Chart + Harding coding
2 participants