Add support for RP-initiated OIDC logout #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
route443
force-pushed
the
rp-initiated-logout
branch
from
dae4ed3 to
ded18f2
Compare
Implement support for RP-initiated logout in accordance with OpenID Connect RP-Initiated Logout 1.0. Introduce "oidc_end_session_endpoint" variable to specify the "end_session_endpoint" URL. If "oidc_end_session_endpoint" is not set or is empty, the default behavior of logging out only on the NGINX side is maintained. When set, the endpoint triggers the RP-initiated logout as specified in the specification.
route443
force-pushed
the
rp-initiated-logout
branch
from
ded18f2 to
323e6f9
Compare
mtbChef
reviewed
Jun 28, 2024
mtbChef
approved these changes
Jun 28, 2024
|
Hey @route443, Do you plan to create a PR to update the current files https://github.com/nginxinc/kubernetes-ingress/tree/main/internal/configs/oidc with your latest changes? Thank you with this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for RP-initiated logout in accordance with OpenID Connect RP-Initiated Logout 1.0. Introduce the
oidc_end_session_endpointvariable to specify theend_session_endpointURL.If
oidc_end_session_endpointis not set or is empty, the default behavior of logging out only on the NGINX side is maintained. When set, the endpoint triggers the RP-initiated logout as specified in the OIDC specification.This PR is based on the revised PR #87 initially submitted by user @llomgui. Thank you to @llomgui for the initial implementation and contribution.
Summary of Changes
oidc_end_session_endpointvariable to specify the OIDC end session endpoint URL.logoutfunction to:end_session_endpoint.session_jwtis expired.