Support sending custom headers to export endpoint #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-pautov
force-pushed
the
dev/headers
branch
from
b3df4ac to
ff12746
Compare
Previously, the error was caused by enormous std::string allocation.
Also, replace leftover cast with getMainConf().
The headers are configured by "header" directive in "otel_exporter" block, e.g.
otel_exporter {
endpoint localhost:4317;
header X-API-Token "token value";
}
p-pautov
force-pushed
the
dev/headers
branch
from
ff12746 to
57452f7
Compare
jimf5
reviewed
Dec 20, 2024
p-pautov
force-pushed
the
dev/headers
branch
from
57452f7 to
a0103d1
Compare
|
Looks good |
dplotnikov-f5
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headers are configured by "header" directive in "otel_exporter" block, e.g.