Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ReadHeaderTimeout to http.Server #283

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Add ReadHeaderTimeout to http.Server #283

merged 1 commit into from
Jul 21, 2022

Conversation

lucacome
Copy link
Member

Adds timeout to fix

G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server (gosec)

@lucacome lucacome requested a review from a team July 21, 2022 16:08
@lucacome lucacome self-assigned this Jul 21, 2022
@github-actions github-actions bot added the bug An issue reporting a potential bug label Jul 21, 2022
jjngx
jjngx approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@lucacome lucacome merged commit f452ae5 into main Jul 21, 2022
@lucacome lucacome deleted the fix/add-timeout branch July 21, 2022 16:43
@vin01 vin01 mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@haywoodsh haywoodsh Awaiting requested review from haywoodsh haywoodsh was automatically assigned from nginxinc/kic

@shaun-nx shaun-nx Awaiting requested review from shaun-nx shaun-nx was automatically assigned from nginxinc/kic

Assignees

@lucacome lucacome

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacome @jjngx