Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not expose zone sync metric if not present #55

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Do not expose zone sync metric if not present #55

merged 1 commit into from
Jun 10, 2019

Conversation

Rulox
Copy link

@Rulox Rulox commented Jun 5, 2019 •
edited
Loading

Proposed changes

  • If zone sync metrics are not present (nil) do not expose them, for consistency.

@Rulox Rulox requested a review from pleshakov June 5, 2019 14:35
@Rulox Rulox self-assigned this Jun 5, 2019
pleshakov
pleshakov approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rulox Rulox merged commit aca0fa4 into master Jun 10, 2019
@Rulox Rulox deleted the fix-zone-sync branch June 10, 2019 14:33
@Rulox Rulox added the bug An issue reporting a potential bug label Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov approved these changes

Assignees

@Rulox Rulox

Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rulox @pleshakov