set user agent on scrape requests to nginx. #70
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This changes the User-Agent header that is being sent when calling nginx stats endpoint.
Currently, the User-Agent is the default Go Http client user agent string (
Go-http-client/1.1
), which is not very useful when looking at nginx logs.This will change it to be
NGINX-Prometheus-Exporter/v0.5.0
(with the version we get when building the docker image)I have tested locally (with a custom docker image) in my k8s cluster (faked the version number when calling docker build).
(ignore the red color, this is just kubetail choosing random colors)
Checklist
Before creating a PR, run through this checklist and mark each as complete.