-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
with admin: | ||
return jsonify(admin.create_users_with_csv(**params)) | ||
|
||
@app.route('/users', methods=['POST']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not common to create users using a csv file. Typically, we add users one by one. But we need to get all users for the front-end.
Have you compared users vs user for the operations against a single user? Both are fine, but we need to be consistent with other APIs. E.g., model vs models, trial vs trials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. I will be removing this API
Changed from deleting user to banning user to avoid complication of having to consider cascade-deleting all associated train jobs / trials / inference jobs / models under that user. |
Can add to documentation: for sudo users need to run
according to https://stackoverflow.com/questions/8633461/how-to-keep-environment-variables-when-using-sudo to preserve the environment variable |
Thanks @wild-flame for the feedback. I've added that to the documentation. |
Fixes #111
Before testing, since Rafiki's v0.1.0 Docker images have not been published to Docker Hub, will need to run
source .env.sh
, thenbash scripts/build_images.sh
for every participating machine.