Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the memory signatures of 5.2 can be found in current CN&KR server, the memory structure is not the same. Since cactbot is going to change the target change event to OverlayPlugin's enmity event as we talked in quisquous/cactbot#1388 (comment), I think it's better to support different clients in advance.
What's more, the downloaded SDK of 2.0.4.0 has no
Chinese
orKorean
enum inFFXIV_ACT_Plugin.Common.Language
, so we need to update the dependency ofFFXIV_ACT_Plugin.Common
to the latest (or near the latest). Maybe we can use the SDK from https://github.com/ravahn/FFXIV_ACT_Plugin/blob/master/Releases/FFXIV_ACT_Plugin_SDK_2.0.5.9.zip.I tested most of the memories in CN server, the enmity module can work well but the hover for target info is not working, probably it's changed from 5.0 to current CN patch 5.15? So I'm thinking whether it's better to have an
EnmityMemoryCn
andEnmityMemoryKr
for different clients.I have no access to KR server so I cannot test there.