Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enmity memory for cn&kr #129

Merged
merged 1 commit into from
May 10, 2020
Merged

enmity memory for cn&kr #129

merged 1 commit into from
May 10, 2020

Conversation

Bluefissure
Copy link

@Bluefissure Bluefissure commented May 6, 2020

Though the memory signatures of 5.2 can be found in current CN&KR server, the memory structure is not the same. Since cactbot is going to change the target change event to OverlayPlugin's enmity event as we talked in quisquous/cactbot#1388 (comment), I think it's better to support different clients in advance.

What's more, the downloaded SDK of 2.0.4.0 has no Chinese or Korean enum in FFXIV_ACT_Plugin.Common.Language, so we need to update the dependency of FFXIV_ACT_Plugin.Common to the latest (or near the latest). Maybe we can use the SDK from https://github.com/ravahn/FFXIV_ACT_Plugin/blob/master/Releases/FFXIV_ACT_Plugin_SDK_2.0.5.9.zip.

I tested most of the memories in CN server, the enmity module can work well but the hover for target info is not working, probably it's changed from 5.0 to current CN patch 5.15? So I'm thinking whether it's better to have an EnmityMemoryCn and EnmityMemoryKr for different clients.

I have no access to KR server so I cannot test there.

@ngld ngld merged commit 7aedcc1 into ngld:master May 10, 2020
@ngld
Copy link
Owner

ngld commented May 10, 2020

The hover target offset might've been broken in 5.15 elsewhere as well. I'm not sure since there are only a few people who use it and I haven't verified it myself. If it turns out that the hover target offset is different for KR and CN, I'll add new EnmityMemory* classes. If it's the same, I'll just fix it in EnmityMemory50.

Updating the SDK is fine. I stayed on the old SDK because there were some players that wanted to use OverlayPlugin with an old version of the parser (IIRC that was a KR player before the plugin officially support KR servers). I need to update the SDK anyway for some other stuff I want to do.

Thanks for the PR and for testing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants