Add options for ending encounters after wipes and out of game combat #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not clear that "EnmityMemory" is the best place for this, but it seemed better to put it with code that was roughly similar and already doing the same sort of memory polling, rather than create separate memory classes for this one off signature.
This adds two opt-in event settings for ending encounters, one on wipe and one five seconds (non-configurable) after game combat ends. This is already implemented in both cactbot and Triggernometry, and so it makes some sense to consolidate these options in one place where they can be useful to everybody. The "five seconds" combat option is intended for the use cases of older fights (such as ARR/HW where the Network6D line is not sent) and dungeons (to split before a boss).
|
Thanks a lot (and to @KattTails, too)! I'm sorry it took so long for me to get around to merging this. RL kept me busy. |
sandtechnology
pushed a commit
to sandtechnology/OverlayPlugin
that referenced
this pull request
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds common OverlayPlugin logic for the Network6D wipe lines, that is already implemented in both cactbot and Triggernometry.
This also reimplements the work from @KattTails in this cactbot branch to end encounters after a set amount of time.