Support for Finnish language and tiny size setting #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannekalliola
changed the title
ngnijland
requested changes
Jul 6, 2023
There was a problem hiding this comment.
Hi @jannekalliola! Thanks for taking the time to create a pull request to this module! Overall the changes look rock solid 🙏
I did add one comment on the implementation of the font-size for the tiny size config. Let me know if you have any questions.
|
@jannekalliola the pipelines fail on two linter errors. If fix those I'll merge the PR! |
ngnijland
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Finnish language and also a smaller than small size ("tiny"), as Finnish words are quite long and the clock would not fit to my screen even on small setting.