Add Heroicons #85
Closed
Add Heroicons #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cody-dot-js
reviewed
Dec 4, 2023
Co-authored-by: Cody Price <34115417+cody-dot-js@users.noreply.github.com>
|
Closing to explore Phosphor instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Heroicons as a dependency and specs their icons throughout our existing components and their examples. Visually, not much should change, but this moves our custom icons into a true external dependency.
One custom icon remains—the copy icon in CodeBlocks. I wasn't happy with the options from Heroicons so we drew our own there.