-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the default name of the pod #179
Labels
Comments
alex-bezek
added
bug
Something isn't working
area/controller
Issues dealing with the controller
needs-triage
Issues that need triage
and removed
needs-triage
Issues that need triage
labels
Mar 13, 2023
Current name outcome matrix
for example:
@nijikokun the current naming scheme is undesirable to customers. I think it would be advantages to just drop the |
This ideally would mean we wouldn't have to change the repository name as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
What happened
The default pod name created by our helm chart is overly verbose and confusing. It should be shortned to be more clear and guessable.
What you think should happen instead
The current name is
ngrok-ingress-controller-kubernetes-ingress-controller-manager
for me because it combines the release name and the default name https://github.com/ngrok/kubernetes-ingress-controller/blob/main/helm/ingress-controller/templates/_helpers.tpl#L28Instead of using the regular name and the chart release name, we should just use the override if provided.
How to reproduce
install the chart and get the pods
This is related to https://github.com/ngrok/kubernetes-ingress-controller/issues/87 since the name is important for your ability to install multiple instances
The text was updated successfully, but these errors were encountered: