Alex/cache stores #129
Merged
Alex/cache stores #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Creates the basic Store and CacheStores with getter/setter functions for managing our ingress and CRD resources
How
cachestores is an in-memory cache being used to back the store. The majority of its actual logic is around filtering out ingress classes. After having done this, I now wonder if it would have been easier to just use a predicate filter to ignore non-matching ingresses and just never add them to the store. We can always delete code and go that way in the future if we want
Breaking Changes
none, this is new