Some updates to handle different cases for e2e run #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes that made the e2e tests work for me, these may not be universally applicable, so happy to cherry pick anything that is actually useful.
How
e2e-fixtures/hello-world-ingress
to removebezek-hello-world-ingress-2
and set via confige2e-fixtures/ingress-class
404 is HTTP/2 for meNGROK
prefix, unlike the environment variables they setjq
andyq
weren't installed on this machine, added to nix config, and added some bash to check for them up front. looks like josh is adding nix support though, so this may become irrelevant.GOOGLE_CLIENT_ID
to not error out if not defined, due to theset -eu -o pipefail
Breaking Changes
N/A