tunneldriver: use the ngrok-go provided forwarding mechanism #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
jrobsonchase
force-pushed
the
josh/ngrok-go-forward
branch
from
150a056 to
ce9a015
Compare
Abdiramen
reviewed
Nov 30, 2023
go.mod
Outdated
| github.com/stretchr/testify v1.8.1 | ||
| golang.ngrok.com/ngrok v1.4.0 | ||
| github.com/stretchr/testify v1.8.4 | ||
| golang.ngrok.com/ngrok v1.6.1-0.20231129180200-b8b5d7fcf1d0 |
There was a problem hiding this comment.
Is this pointing to ngrok-go/main?
There was a problem hiding this comment.
Yeah - probably doesn't need to though. Pretty sure this feature is released.
|
Ugh, I forgot that we haven't added the options for making the forwarding TLS config use Back to draft it goes. |
|
@jrobsonchase what are the next steps on this ticket? |
jrobsonchase
force-pushed
the
josh/ngrok-go-forward
branch
2 times, most recently
from
47f96e2 to
681df85
Compare
jrobsonchase
force-pushed
the
josh/ngrok-go-forward
branch
from
681df85 to
9f5aa46
Compare
|
@jonstacks @deroine @alex-bezek heads up we're closing this for cleanup, feel free to reopen if it's still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use the upstream
ListenAndForwardAPI instead of reimplementing the connection join logic.This also lets us lean on the upstream TLS terminating semantics and (soon) its HTTP/2 interaction with TLS.
How
Remove
handleConnsandhandleConnin favor of thengrok-goprovided API.Breaking Changes
None