Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extensionRef support for policy crd inclusion #377

Merged
merged 1 commit into from
May 20, 2024
Merged

Add extensionRef support for policy crd inclusion #377

merged 1 commit into from
May 20, 2024

Conversation

bobzilladev
Copy link
Contributor

What

Adds ability for gateway api to use extensionRef to include a Policy CRD.

How

Adding a filter like this will plumb the policy data through:

- type: ExtensionRef
  extensionRef:
     group: ngrok.k8s.ngrok.com
     kind: NgrokTrafficPolicy
     name: my-traffic-policy

Breaking Changes

No

@bobzilladev bobzilladev requested a review from a team as a code owner May 17, 2024 17:59
@github-actions github-actions bot added the area/controller Issues dealing with the controller label May 17, 2024
Abdiramen
Abdiramen approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@Abdiramen Abdiramen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I like the use of that lambda

@bobzilladev bobzilladev merged commit 952a62e into main May 20, 2024
7 checks passed
@bobzilladev bobzilladev deleted the bob/gw-extension-ref branch May 20, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abdiramen Abdiramen Abdiramen approved these changes

@OfTheDelmer OfTheDelmer Awaiting requested review from OfTheDelmer

Assignees
No one assigned
Labels
area/controller Issues dealing with the controller
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobzilladev @Abdiramen