refactor: Easier to read driver seed #411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
There are a some places where I think we can use generics and other methods to make the code easier to read, maintain, and test. The initial seed was one of those places that can benefit from this. I think we can also re-use the new
internal/util
package in more places too.How
[]T
, where*T
implementsclient.Object
, and returns[]client.Object
[]client.Object
This is slightly less memory efficient as rather than getting a pointer for each item before we call the store to update it, we pre-compute a slice with all pointers. This seemed like an acceptable trade-off for making the code easier to read and manage.
Breaking Changes
No