Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test starting an ngrok agent in CI #523

Open
wants to merge 63 commits into
base: main
Choose a base branch
from
Open

Test starting an ngrok agent in CI #523

wants to merge 63 commits into from

Conversation

hjkatz
Copy link
Contributor

@hjkatz hjkatz commented Nov 15, 2024 •
edited
Loading

What

Describe what the change is solving

  • Moves e2e tests to Makefile targets
  • Add e2e tests for bindings
  • Use docker daemon connected k3s action in CI
  • Remove extra build step (included in make e2e-deploy)
  • Add e2e tests for ngrok-agent ; Start ngrok agent in CI
  • Move e2e tests into Makefile tasks as possible
  • Add debug steps to CI

How

Describe the solution
Chainsaw

Breaking Changes

Are there any breaking changes in this PR?
No.

@hjkatz hjkatz requested a review from a team as a code owner November 15, 2024 20:52
@hjkatz hjkatz self-assigned this Nov 15, 2024
@github-actions github-actions bot added the area/ci Issues/PRs relating to CI label Nov 15, 2024
@hjkatz hjkatz force-pushed the hkatz/ngrok-agent-ci branch 2 times, most recently from 24b18b2 to 3222ac5 Compare December 11, 2024 16:06
@hjkatz hjkatz enabled auto-merge December 11, 2024 16:09
@hjkatz hjkatz disabled auto-merge December 11, 2024 16:09
@hjkatz hjkatz added this pull request to the merge queue Dec 11, 2024
@hjkatz hjkatz removed this pull request from the merge queue due to a manual request Dec 11, 2024
@hjkatz hjkatz enabled auto-merge December 11, 2024 19:11
@hjkatz hjkatz added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@hjkatz hjkatz enabled auto-merge December 11, 2024 19:29
@hjkatz hjkatz added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@hjkatz hjkatz enabled auto-merge December 11, 2024 20:07
@hjkatz hjkatz added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@hjkatz hjkatz enabled auto-merge December 11, 2024 20:31
@hjkatz hjkatz added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@hjkatz hjkatz added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@hjkatz hjkatz added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@hjkatz hjkatz enabled auto-merge December 12, 2024 15:00
@hjkatz hjkatz added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@hjkatz hjkatz enabled auto-merge December 12, 2024 15:47
hjkatz added 29 commits December 19, 2024 13:45
@hjkatz
Remove accidental extra steps
5336d51
@hjkatz
With specific IMG
e0665b1
@hjkatz
With specific IMG
e908081
@hjkatz
With error on ngrok-op doesn't start
347c513
@hjkatz
With handling registry formatting
c1beac4
@hjkatz
With different k3s action
6e3568d
@hjkatz
Cleanup
f8c94f9
@hjkatz
Ensure tlsSecret is set to the found/created secret
785e1d7
@hjkatz
Remove rebase artifacts
ebd6a56
@hjkatz
With sleep 30s
d054294
@hjkatz
Add tcp-echo asserts
b32e013
@hjkatz
With disabled metrics-server
b5f2e86
@hjkatz
With different k3s provider
8781b87
@hjkatz
With inputs.github-token
7ba402f
@hjkatz
Without k3d args
9bd098f
@hjkatz
With k3d load image
6ff2de8
@hjkatz
With some attempted fixes
8b90a2f
@hjkatz
With result.out
a700e17
@hjkatz
With explicit cat
a6017c2
@hjkatz
WIP: TESTING TESTING
6a920f5
@hjkatz
With corrected opts
882e638
@hjkatz
With timeout
f2d38dc
@hjkatz
Adjust the tcp test too
003405f
@hjkatz
With status as patch
e588eb5
@hjkatz
Fix tests
b617646
@hjkatz
Add kubectl get as well as describe
ba10f21
@hjkatz
With status as patch and get
b6f1954
@hjkatz
With get and patch
0158c23
@hjkatz
Add make _docker-load task
e97b90e
@hjkatz hjkatz force-pushed the hkatz/ngrok-agent-ci branch from 8fbe4ff to e97b90e Compare December 19, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonstacks jonstacks jonstacks approved these changes

Assignees

@hjkatz hjkatz

Labels
area/ci Issues/PRs relating to CI area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjkatz @jonstacks