Skip to content

rustls’s aws-lc-rs backend is enabled unconditionnally #177

@CBenoit

Description

@CBenoit

Confirmed in ngrok v0.15.0.

In futures-rustls’s Cargo.toml, aws-lc-rs is feature enabled by default:

[features]
default = ["aws-lc-rs", "tls12", "logging"] # <- enabling aws-lc-rs by default
aws-lc-rs = ["rustls/aws_lc_rs"]
aws_lc_rs = ["aws-lc-rs"]
early-data = []
fips = ["rustls/fips"]
logging = ["rustls/logging"]
ring = ["rustls/ring"]
tls12 = ["rustls/tls12"]

And in ngrok’s Cargo.toml:

futures-rustls = { version = "0.26.0" }

futures-rustls is depended upon with all the default features.

This prevent the consumer of ngrok to control the backend to be used with rustls.

It would help to expose the same features as futures-rustls to choose between the two.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions