ngrok: auto-rewrite the http host header #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
jrobsonchase
force-pushed
the
josh/auto-rewrite-host
branch
from
5a5f27e to
e3fa602
Compare
Abdiramen
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now implemented by our request header middleware upstream, but this
adds some convenience and docs to it.
Users can call
http_builder.host_header_rewrite(true);to have it setautomatically on
listen_and_forwardcalls, and it also points out the.request_header(...)approach to setting specific values.Also canonicalizes (lowercases, really) header keys to make sure we aren't
sending multiple values for the same differently-cased "Host" header.