Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle StopTunnel message #124

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Handle StopTunnel message #124

merged 4 commits into from
Nov 27, 2023

Conversation

bobzilladev
Copy link
Contributor

No description provided.

Copy link
Contributor

@jrobsonchase jrobsonchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach looks good, just a few type and naming nits that can probably be handled without a re-review.

You can give my suggestions a try, but no promises as to whether they'll work without pulling them down and fixing any formatting/typos by hand 😁

ngrok/src/internals/proto.rs Outdated Show resolved Hide resolved
ngrok/src/internals/raw_session.rs Outdated Show resolved Hide resolved
ngrok/src/tunnel.rs Outdated Show resolved Hide resolved
ngrok/src/internals/proto.rs Outdated Show resolved Hide resolved
@bobzilladev bobzilladev merged commit e39d7a6 into main Nov 27, 2023
11 checks passed
@bobzilladev bobzilladev deleted the bob/burn-notice branch November 27, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants