build: fix Windows build when hyper feature is disabled #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifying the imports in conditional code for Windows.
|
Hello @jrobsonchase I’m not sure who is the appropriate person for that, but it seems that the problem in the CI is unrelated to the changes in my PR. My guess would be a permission problem when an external contributor open a PR, where the CI does not have access to the appropriate secrets. |
|
@CBenoit Thanks for the PR! You're right that the CI error is not your fault. In general, improving the CI on this repository is something we need to get around to. Short-term, let me test this by hand on our matrix and then cut a 1.5.1 build if it looks okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #174
This issue has been closed already because enabling the feature
hyperis fixing the compilation error, but my understanding is that the build being broken when it is not enabled is still accidental and something undesirable that needs to be fixed.In this PR, I fixed that problem, and simplified a little bit the imports in conditional code for Windows by putting the
uses directly into the conditional code.This allow local reasoning, rendering much easier understanding which imports are required when and why, avoiding both compilation errors and warnings various feature combinations.
Advice: ideally, you should test multiple feature combinations in your CI.
cargo-hackis a common way of doing that.Do you think you could also release a hotfix release soon so we can benefit from this quickly, please?