remove the redundant skipRuntimeCheck flag

ngrx · Jul 1, 2019 · 0f384b0 · 0f384b0
1 parent 58f4fd3
commit 0f384b0
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 34 deletions.
diff --git a/modules/schematics/src/store/index.spec.ts b/modules/schematics/src/store/index.spec.ts
@@ -23,7 +23,6 @@ describe('Store Schematic', () => {
     module: undefined,
     flat: false,
     root: true,
-    skipRuntimeCheck: false,
   };
 
   const projectPath = getTestProjectPath();
@@ -249,16 +248,4 @@ describe('Store Schematic', () => {
     expect(content).toMatch(/strictStateImmutability: true,/);
     expect(content).toMatch(/strictActionImmutability: true/);
   });
-
-  it('should not add store runtime checks', () => {
-    const options = {
-      ...defaultOptions,
-      module: 'app.module.ts',
-      skipRuntimeCheck: true,
-    };
-
-    const tree = schematicRunner.runSchematic('store', options, appTree);
-    const content = tree.readContent(`${projectPath}/src/app/app.module.ts`);
-    expect(content).not.toMatch(/, runtimeChecks: {/);
-  });
 });
diff --git a/modules/schematics/src/store/index.ts b/modules/schematics/src/store/index.ts
@@ -28,15 +28,6 @@ import {
 } from '@ngrx/schematics/schematics-core';
 import { Schema as StoreOptions } from './schema';
 
-function addRuntimeChecks(skipRuntimeChecks?: boolean) {
-  return skipRuntimeChecks
-    ? ''
-    : `, runtimeChecks: {
-        strictStateImmutability: true,
-        strictActionImmutability: true
-    }`;
-}
-
 function addImportToNgModule(options: StoreOptions): Rule {
   return (host: Tree) => {
     const modulePath = options.module;
@@ -70,13 +61,16 @@ function addImportToNgModule(options: StoreOptions): Rule {
       `${options.path}/environments/environment`
     );
 
+    const runtimeChecks = `runtimeChecks: {
+        strictStateImmutability: true,
+        strictActionImmutability: true,
+    }`;
+
     const storeNgModuleImport = addImportToModule(
       source,
       modulePath,
       options.root
-        ? `StoreModule.forRoot(reducers, { metaReducers${addRuntimeChecks(
-            options.skipRuntimeCheck
-          )} })`
+        ? `StoreModule.forRoot(reducers, { metaReducers, ${runtimeChecks} })`
         : `StoreModule.forFeature('${stringUtils.camelize(
             options.name
           )}', from${stringUtils.classify(

diff --git a/modules/schematics/src/store/schema.json b/modules/schematics/src/store/schema.json
@@ -54,11 +54,6 @@
       "default": "State",
       "description": "Specifies the interface for the state.",
       "alias": "si"
-    },
-    "skipRuntimeCheck": {
-      "type": "boolean",
-      "default": false,
-      "description": "Flag to skip the store runtime checks"
     }
   },
   "required": []

diff --git a/modules/schematics/src/store/schema.ts b/modules/schematics/src/store/schema.ts
@@ -39,8 +39,4 @@ export interface Schema {
    * Specifies the interface for the state
    */
   stateInterface?: string;
-  /**
-   * Flag to skip the store runtime checks
-   */
-  skipRuntimeCheck?: boolean;
 }