Skip to content

Commit bb9071c

Browse files
perf(component): do not schedule render for synchronous events (#3487)
1 parent 398fbed commit bb9071c

File tree

6 files changed

+244
-30
lines changed

6 files changed

+244
-30
lines changed

modules/component/spec/core/render-event/handlers.spec.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,26 +30,30 @@ describe('combineRenderEventHandlers', () => {
3030
const suspenseEvent: SuspenseRenderEvent = {
3131
type: 'suspense',
3232
reset: true,
33+
synchronous: true,
3334
};
3435
testRenderEvent(suspenseEvent);
3536

3637
const nextEvent: NextRenderEvent<number> = {
3738
type: 'next',
3839
value: 1,
3940
reset: true,
41+
synchronous: false,
4042
};
4143
testRenderEvent(nextEvent);
4244

4345
const errorEvent: ErrorRenderEvent = {
4446
type: 'error',
4547
error: 'ERROR!',
4648
reset: false,
49+
synchronous: true,
4750
};
4851
testRenderEvent(errorEvent);
4952

5053
const completeEvent: CompleteRenderEvent = {
5154
type: 'complete',
5255
reset: false,
56+
synchronous: false,
5357
};
5458
testRenderEvent(completeEvent);
5559
});

0 commit comments

Comments
 (0)