perf(component): do not schedule render for synchronous events #3487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The render scheduler unnecessarily schedules render/marks a component as dirty when synchronous events are emitted.
For instance, in the following example:
The PushPipe will mark
TestComponent
as dirty (and schedule tick in zone-less mode) 4 times (3 next, and 1 complete event) which is not needed because all these events will be emitted synchronously, so the last value will be visible in the template without scheduling render/marking it as dirty.What is the new behavior?
The render scheduler schedules render/marks a component as dirty only when asynchronous events are emitted.
Does this PR introduce a breaking change?