refactor(example-app): use action creators

ngrx · Mar 2, 2019 · c8fc6b9 · c8fc6b9
1 parent 9f9d2a3
commit c8fc6b9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 35 deletions.
diff --git a/projects/example-app/src/app/auth/actions/auth-api.actions.ts b/projects/example-app/src/app/auth/actions/auth-api.actions.ts
@@ -1,7 +1,7 @@
 import { ActionsUnion, createAction } from '@ngrx/store';
 import { User } from '@example-app/auth/models/user';
 
-export const enum AuthApiActionTypes {
+export enum AuthApiActionTypes {
   LoginSuccess = '[Auth/API] Login Success',
   LoginFailure = '[Auth/API] Login Failure',
   LoginRedirect = '[Auth/API] Login Redirect',
@@ -16,23 +16,3 @@ export const AuthApiActions = {
 };
 
 export type AuthApiActions = ActionsUnion<typeof AuthApiActions>;
-
-/*
-export class LoginSuccess implements Action {
-  readonly type = AuthApiActionTypes.LoginSuccess;
-
-  constructor(public payload: { user: User }) {}
-}
-
-export class LoginFailure implements Action {
-  readonly type = AuthApiActionTypes.LoginFailure;
-
-  constructor(public payload: { error: any }) {}
-}
-
-export class LoginRedirect implements Action {
-  readonly type = AuthApiActionTypes.LoginRedirect;
-}
-
-export type AuthApiActionsUnion = LoginSuccess | LoginFailure | LoginRedirect;
-*/
diff --git a/projects/example-app/src/app/auth/actions/index.ts b/projects/example-app/src/app/auth/actions/index.ts
@@ -1,15 +1,6 @@
-import {
-  AuthActions,
-  AuthActionTypes,
-} from '@example-app/auth/actions/auth.actions';
-import {
-  AuthApiActions,
-  AuthApiActionTypes,
-} from '@example-app/auth/actions/auth-api.actions';
-import {
-  LoginPageActions,
-  LoginPageActionTypes,
-} from '@example-app/auth/actions/login-page.actions';
+import { AuthActions, AuthActionTypes } from './auth.actions';
+import { AuthApiActions, AuthApiActionTypes } from './auth-api.actions';
+import { LoginPageActions, LoginPageActionTypes } from './login-page.actions';
 
 export {
   AuthActions,

diff --git a/projects/example-app/src/app/auth/actions/login-page.actions.ts b/projects/example-app/src/app/auth/actions/login-page.actions.ts
@@ -1,7 +1,7 @@
 import { ActionsUnion, createAction } from '@ngrx/store';
 import { Credentials } from '@example-app/auth/models/user';
 
-export const enum LoginPageActionTypes {
+export enum LoginPageActionTypes {
   Login = '[Login Page] Login',
 }
 

diff --git a/projects/example-app/src/app/auth/effects/auth.effects.ts b/projects/example-app/src/app/auth/effects/auth.effects.ts
@@ -24,7 +24,6 @@ export class AuthEffects {
     map(action => action.credentials),
     exhaustMap((auth: Credentials) =>
       this.authService.login(auth).pipe(
-        // map(user => AuthApiActions.AuthApiActions.loginSuccess(user)),
         map(AuthApiActions.loginSuccess),
         catchError(error => of(AuthApiActions.loginFailure(error)))
       )