fix(router-store): selects should return selectors

ngrx · May 7, 2020 · eef5e91 · eef5e91
1 parent d9c00b7
commit eef5e91
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/modules/router-store/spec/BUILD b/modules/router-store/spec/BUILD
@@ -12,6 +12,7 @@ ts_test_library(
         "//modules/store",
         "@npm//@angular/router",
         "@npm//rxjs",
+        "@npm//ts-snippet",
     ],
 )
 

diff --git a/modules/router-store/src/models.ts b/modules/router-store/src/models.ts
@@ -1,11 +1,12 @@
-import { Data, Params } from '@angular/router';
+import { Params, Data } from '@angular/router';
+import { MemoizedSelector } from '@ngrx/store';
 
 export interface RouterStateSelectors<V> {
-  selectCurrentRoute: (state: V) => any;
-  selectQueryParams: (state: V) => Params;
-  selectQueryParam: (param: string) => (state: V) => string | undefined;
-  selectRouteParams: (state: V) => Params;
-  selectRouteParam: (param: string) => (state: V) => string | undefined;
-  selectRouteData: (state: V) => Data;
-  selectUrl: (state: V) => string;
+  selectCurrentRoute: MemoizedSelector<V, any>;
+  selectQueryParams: MemoizedSelector<V, Params>;
+  selectQueryParam: (param: string) => MemoizedSelector<V, string | undefined>;
+  selectRouteParams: MemoizedSelector<V, Params>;
+  selectRouteParam: (param: string) => MemoizedSelector<V, string | undefined>;
+  selectRouteData: MemoizedSelector<V, Data>;
+  selectUrl: MemoizedSelector<V, string>;
 }