Skip to content

Commit

Permalink
fix(schematics): Remove peer dependencies on Angular DevKit (#1222)
Browse files Browse the repository at this point in the history
The peer dependencies prevent you from using `ng update` since the CLI is pinned to specific versions. We'll verify the schematics work across versions and rely on the dependencies provided implicitly with the CLI

Closes #1206
  • Loading branch information
brandonroberts authored Aug 1, 2018
1 parent 73d32eb commit fd3da16
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
4 changes: 0 additions & 4 deletions modules/schematics/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,5 @@
"ng-update": {
"packageGroup": "NG_UPDATE_PACKAGE_GROUP",
"migrations": "NG_UPDATE_MIGRATIONS"
},
"peerDependencies": {
"@angular-devkit/core": "NG_DEVKIT_VERSION",
"@angular-devkit/schematics": "NG_DEVKIT_VERSION"
}
}
2 changes: 0 additions & 2 deletions tools/defaults.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ load("@build_bazel_rules_nodejs//:defs.bzl",
DEFAULT_TSCONFIG = "//:tsconfig.json"
NG_VERSION = "^6.0.0"
RXJS_VERSION = "^5.6.0-forward-compat.0 || ^6.0.0"
NG_DEVKIT_VERSION = "^0.6.0"
NG_UPDATE_MIGRATIONS = "./migrations/migration.json"
MODULE_SCHEMATICS_COLLECTION = "./schematics/collection.json"

Expand All @@ -30,7 +29,6 @@ PKG_GROUP_REPLACEMENTS = {
"\"NG_UPDATE_PACKAGE_GROUP\"": """[
%s
]""" % ",\n ".join(["\"%s\"" % s for s in NGRX_SCOPED_PACKAGES]),
"NG_DEVKIT_VERSION": NG_DEVKIT_VERSION,
"NG_UPDATE_MIGRATIONS": NG_UPDATE_MIGRATIONS,
"MODULE_SCHEMATICS_COLLECTION": MODULE_SCHEMATICS_COLLECTION,
}
Expand Down

0 comments on commit fd3da16

Please sign in to comment.