Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.0.0-beta has wrong global variable in UMD #1004

Closed
alexeagle opened this issue Apr 30, 2018 · 1 comment
Closed

6.0.0-beta has wrong global variable in UMD #1004

alexeagle opened this issue Apr 30, 2018 · 1 comment

Comments

@alexeagle
Copy link
Contributor

https://unpkg.com/@ngrx/store@5.2.0/bundles/store.umd.js

defines a variable global.ngrx.store

https://unpkg.com/@ngrx/store@6.0.0-beta.1/bundles/store.umd.js

defines global.npm_package

this was an issue in the Angular build as well since we use the bazel ng_package rule - I'll send a PR to fix this.
@alexeagle
Copy link
Contributor Author

reported by @gregmagolan

alexeagle added a commit to alexeagle/platform that referenced this issue Apr 30, 2018
@alexeagle
Update Angular to 6 rc.6
fbc6880 
Fixes ngrx#1004
@GulajavaMinistudio GulajavaMinistudio mentioned this issue Apr 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexeagle