Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can StoreDevtoolsModule export provider INITIAL_OPTIONS for better consumption? #1470

Closed
ttestman4 opened this issue Dec 15, 2018 · 4 comments

Comments

@ttestman4
Copy link
Contributor

ttestman4 commented Dec 15, 2018

StoreDevtoolsModule need way to inject option when the entire structure is part of reusable library for large scale project. Please find the attached sample where, logOnly option needs to flow from application to library to pass to the StoreDevtoolModule. My understanding is INITIAL_OPTIONS provider should be exported on the lines of META_REDUCERS

Reproduction project sample:
https://github.com/ttestman4/sampleapp1/blob/develop/projects/non-functional/src/lib/root-store/root-store.module.ts Line #40

also deployed on https://ttestman4.github.io/sampleapp1/index.html

Describe any alternatives/workarounds you're currently using

I do not find alternative.

Other information:

This is low priority issue but vital for large scale application design.

If accepted, I would be willing to submit a PR for this feature

[X] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@brandonroberts
Copy link
Member

Seems reasonable to me if you're still willing to submit a PR.

@maartentibau
Copy link
Contributor

@brandonroberts @timdeschryver @alex-okrushko is there still interest to add this? If so I might be able to have a look at this.

@brandonroberts
Copy link
Member

@maartentibau yea, its still open for contribution.

@brandonroberts
Copy link
Member

Closing for now. Will reopen if there is interest in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants