Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematics: Add schematics for action creators #1670

Closed
brandonroberts opened this issue Mar 31, 2019 · 5 comments · Fixed by #1765
Closed

Schematics: Add schematics for action creators #1670

brandonroberts opened this issue Mar 31, 2019 · 5 comments · Fixed by #1765

Comments

@brandonroberts
Copy link
Member

Follow up to #1480

  1. Adds an actionCreators option to the action, feature, entity schematics that uses the new action creator functions instead of classes
  2. The actionCreators flag will use a different set of files for scaffolding. This keeps our current structure with files intact.
  3. Adds tests to verify the behavior of the previously mentioned schematics
@timdeschryver
Copy link
Member

What about making actionCreators the default (and make it our recommended way)?
We already have refactored the example app and are currently busy updating the docs.

@brandonroberts
Copy link
Member Author

brandonroberts commented Apr 5, 2019

I'd rather it be opt-in for 8 and the default for 9. We'll see how the betas go and revisit.

@brandonroberts brandonroberts self-assigned this Apr 10, 2019
@jtcrowson
Copy link
Contributor

Happy to pick this up if it's still up for grabs.

@timdeschryver
Copy link
Member

If I'm not mistaken, I think @brandonroberts has started on this.

@brandonroberts
Copy link
Member Author

Yep, I have a branch here. https://github.com/ngrx/platform/tree/schematics-action-creators

If you want to take it, that's fine with me. It will need to land after #1725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants