We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ng-add
Create a new application, install ngrx-data, run ng add @ngrx/data --beta --migrateNgrxData
ngrx-data
ng add @ngrx/data --beta --migrateNgrxData
It should replace the ngrx-data to @ngrx/data in the package.json but this isn't the case.
@ngrx/data
package.json
v8-beta.1
In order to solve this we should change the following lines:
https://github.com/ngrx/platform/blob/master/modules/data/schematics/ng-add/index.ts#L96
After this step we should probably also fix the failing tests 😃 Run npm run test:unit to run the unit tests.
npm run test:unit
[ ] Yes (Assistance is provided if you need help submitting a pull request) [ ] No
The text was updated successfully, but these errors were encountered:
fix(data): the correct package name is ngrx-data
bfe0f9a
Closes #1802
fix(data): update the package name for replacement to ngrx-data (#1805)
00c00e0
Successfully merging a pull request may close this issue.
Minimal reproduction of the bug/regression with instructions:
Create a new application, install
ngrx-data
, runng add @ngrx/data --beta --migrateNgrxData
Expected behavior:
It should replace the
ngrx-data
to@ngrx/data
in thepackage.json
but this isn't the case.Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):
v8-beta.1
Other information:
In order to solve this we should change the following lines:
https://github.com/ngrx/platform/blob/master/modules/data/schematics/ng-add/index.ts#L96
After this step we should probably also fix the failing tests 😃
Run
npm run test:unit
to run the unit tests.I would be willing to submit a PR to fix this issue
[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
The text was updated successfully, but these errors were encountered: