Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong package name in the ng-add schematic to replace ngrx-data #1802

Closed
timdeschryver opened this issue Apr 24, 2019 · 0 comments · Fixed by #1805
Closed

Wrong package name in the ng-add schematic to replace ngrx-data #1802

timdeschryver opened this issue Apr 24, 2019 · 0 comments · Fixed by #1805

Comments

@timdeschryver
Copy link
Member

Minimal reproduction of the bug/regression with instructions:

Create a new application, install ngrx-data, run ng add @ngrx/data --beta --migrateNgrxData

Expected behavior:

It should replace the ngrx-data to @ngrx/data in the package.json but this isn't the case.

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):

v8-beta.1

Other information:

In order to solve this we should change the following lines:

https://github.com/ngrx/platform/blob/master/modules/data/schematics/ng-add/index.ts#L96

After this step we should probably also fix the failing tests 😃
Run npm run test:unit to run the unit tests.

I would be willing to submit a PR to fix this issue

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant