Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: createSelectorFactory should return a MemoizedSelector #1883

Merged
merged 2 commits into from
May 22, 2019

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1849

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

BREAKING CHANGE:
The return type of the createSelectorFactory function is now a MemoizedSelector instead of a Selector

BREAKING CHANGE:
The return type of the createSelectorFactory function is now a MemoizedSelector instead of a Selector
@ngrxbot
Copy link
Collaborator

ngrxbot commented May 22, 2019

Preview docs changes for cb50067 at https://previews.ngrx.io/pr1883-cb50067/

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 22, 2019

Preview docs changes for 360a2e1 at https://previews.ngrx.io/pr1883-360a2e1/

@brandonroberts brandonroberts merged commit 8b31da7 into master May 22, 2019
@brandonroberts brandonroberts deleted the pr/1849 branch May 22, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store: createSelectorFactory should be returning MemoizedSelector instead of Selector
3 participants