Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store: runtime checks token typo #1972

Closed
timdeschryver opened this issue Jun 25, 2019 · 1 comment · Fixed by #1975
Closed

Store: runtime checks token typo #1972

timdeschryver opened this issue Jun 25, 2019 · 1 comment · Fixed by #1975
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Good First Issue Good issue for first-time contributor Project: Store

Comments

@timdeschryver
Copy link
Member

Minimal reproduction of the bug/regression with instructions:

There is a typo at:

https://github.com/ngrx/platform/blob/master/modules/store/src/tokens.ts#L76

It should be:

export const _ACTIVE_RUNTIME_CHECKS = new InjectionToken<RuntimeChecks>(
  '@ngrx/store Internal Runtime Checks'
);
@timdeschryver timdeschryver added Project: Store Accepting PRs Good First Issue Good issue for first-time contributor labels Jun 25, 2019
@jtcrowson
Copy link
Contributor

Nice and easy! I got it.

@jtcrowson jtcrowson mentioned this issue Jun 25, 2019
Merged
1 task
@timdeschryver timdeschryver added the community watch Someone from the community is working this issue/PR label Jun 26, 2019
brandonroberts pushed a commit that referenced this issue Jun 27, 2019
@brandonroberts
fix(store): fix typo in runtime checks injection token description (#…
125d950 
…1975)

Closes #1972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs community watch Someone from the community is working this issue/PR Good First Issue Good issue for first-time contributor Project: Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(store): fix typo in runtime checks injection token description jtcrowson/platform
2 participants
@jtcrowson @timdeschryver