-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Immutability check reducer is not compatible with IE11 #1991
Comments
Can you reproduce it with the ngrx example-app located in this project? |
IE errors when attempting to access the `caller` property of a function, so rearrange the freeze function to check for this first. Fixes ngrx#1991
The underlying issue was that one of the objects in our store had a function property. You can reproduce it in the example app by adding a function to the initial state of some some reducer. See the PR I submitted for more info. This bug also showed up in ngrx-store-freeze: brandonroberts/ngrx-store-freeze#7 |
IE errors when attempting to access the `caller` property of a function, so rearrange the freeze function to check for this first. Fixes #1991
IE errors when attempting to access the `caller` property of a function, so rearrange the freeze function to check for this first. Fixes ngrx#1991
Minimal reproduction of the bug/regression with instructions:
Can't include a repro as StackBlitz does not work in IE11.
Trying to run an app that uses NgRx in 11 in non-prod mode produces the following error:
It occurs here:
platform/modules/store/src/meta-reducers/immutability_reducer.ts
Line 23 in c59c211
Seems to be the same issue as this: https://github.com/substack/deep-freeze/issues/6
Expected behavior:
Using NgRx in dev mode in IE11 should work.
Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):
Angular 8
NgRx 8
Internet Explorer 11
Other information:
I would be willing to submit a PR to fix this issue
[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
The text was updated successfully, but these errors were encountered: