Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immutability check reducer is not compatible with IE11 #1991

Closed
jonr-elsewhen opened this issue Jul 3, 2019 · 2 comments · Fixed by #1997
Closed

Immutability check reducer is not compatible with IE11 #1991

jonr-elsewhen opened this issue Jul 3, 2019 · 2 comments · Fixed by #1997
Assignees

Comments

@jonr-elsewhen
Copy link

Minimal reproduction of the bug/regression with instructions:

Can't include a repro as StackBlitz does not work in IE11.

Trying to run an app that uses NgRx in 11 in non-prod mode produces the following error:

ERROR TypeError: Accessing the 'caller' property of a function or arguments object is not allowed in strict mode

It occurs here:

Seems to be the same issue as this: https://github.com/substack/deep-freeze/issues/6

Expected behavior:

Using NgRx in dev mode in IE11 should work.

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):

Angular 8
NgRx 8
Internet Explorer 11

Other information:

I would be willing to submit a PR to fix this issue

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@timdeschryver
Copy link
Member

Can you reproduce it with the ngrx example-app located in this project?
If I open up the example app, I can't reproduce this behavior.

jonrimmer added a commit to jonrimmer/platform that referenced this issue Jul 4, 2019
IE errors when attempting to access the `caller` property of a function,
so rearrange the freeze function to check for this first.

Fixes ngrx#1991
@jonr-elsewhen
Copy link
Author

The underlying issue was that one of the objects in our store had a function property. You can reproduce it in the example app by adding a function to the initial state of some some reducer.

See the PR I submitted for more info. This bug also showed up in ngrx-store-freeze: brandonroberts/ngrx-store-freeze#7

brandonroberts pushed a commit that referenced this issue Jul 5, 2019
IE errors when attempting to access the `caller` property of a function,
so rearrange the freeze function to check for this first.

Fixes #1991
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this issue Nov 14, 2019
IE errors when attempting to access the `caller` property of a function,
so rearrange the freeze function to check for this first.

Fixes ngrx#1991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants