Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ngrx/store: StoreConfig interface missing from exports. #2007

Closed
bhalash opened this issue Jul 11, 2019 · 3 comments · Fixed by #2009
Closed

@ngrx/store: StoreConfig interface missing from exports. #2007

bhalash opened this issue Jul 11, 2019 · 3 comments · Fixed by #2009
Assignees
Labels

Comments

@bhalash
Copy link
Contributor

bhalash commented Jul 11, 2019

Minimal reproduction of the bug/regression with instructions:

This does not require StackBlitz. It appears to be a simple case of either a missing export or incorrect documentation.

Expected behavior:

In the guide, Using Dependency Injection -> Injecting Feature Config states that you should import StoreConfig:

import { StoreModule, StoreConfig } from '@ngrx/store';

Looking at the source I find that store_module.ts declares the interface, but index.ts in the same folder does not re-export StoreConfig.

Screenshot 2019-07-11 at 12 57 39

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):

  • NgRx: 8.1.0
  • Angular: 8.1.0

Other information:

I would be willing to submit a PR to fix this issue

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@brandonroberts
Copy link
Member

Good catch. Go for it

@timdeschryver
Copy link
Member

While we're at it we also should export RootStoreConfig

@bhalash
Copy link
Contributor Author

bhalash commented Jul 11, 2019

Done and done, PR open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants