We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This does not require StackBlitz. It appears to be a simple case of either a missing export or incorrect documentation.
In the guide, Using Dependency Injection -> Injecting Feature Config states that you should import StoreConfig:
StoreConfig
import { StoreModule, StoreConfig } from '@ngrx/store';
Looking at the source I find that store_module.ts declares the interface, but index.ts in the same folder does not re-export StoreConfig.
8.1.0
[x] Yes (Assistance is provided if you need help submitting a pull request) [ ] No
The text was updated successfully, but these errors were encountered:
Good catch. Go for it
Sorry, something went wrong.
While we're at it we also should export RootStoreConfig
RootStoreConfig
Done and done, PR open.
fix(store): add missing StoreConfig and RootStoreConfig exports (#2009)
5e01e50
Closes #2007
fix(store): add missing StoreConfig and RootStoreConfig exports (ngrx…
be5ca63
…#2009) Closes ngrx#2007
bhalash
Successfully merging a pull request may close this issue.
Minimal reproduction of the bug/regression with instructions:
This does not require StackBlitz. It appears to be a simple case of either a missing export or incorrect documentation.
Expected behavior:
In the guide, Using Dependency Injection -> Injecting Feature Config states that you should import
StoreConfig
:Looking at the source I find that store_module.ts declares the interface, but index.ts in the same folder does not re-export
StoreConfig
.Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):
8.1.0
8.1.0
Other information:
I would be willing to submit a PR to fix this issue
[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
The text was updated successfully, but these errors were encountered: