feature(store): catch action creators being passed to dispatch without () even sooner

[alex-okrushko]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

During the recent merge of NgRx to Google I discovered a number of dispatch calls of new action creators without actual calls, e.g. store.dispatch(fooAction) instead of store.dispatch(fooAction()).

In NgRx we already added the runtime check, but I think we can do even better and catch it at compile time (IDEs will catch this too).

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Errors (warnings) at runtime

What is the new behavior?

Type Error: Functions are not allowed to be dispatched. Did you forget to call action creator?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

[ngrxbot]

Preview docs changes for 397ab6d at https://previews.ngrx.io/pr2306-397ab6d/

[erhise]

This is of insignificant importance to say the least but when I read Did you forget to call action creator? the first time I was a little bit confused for a second.

I wonder if the error message can be improved to something like

• Did you forget to call the action creator function? or
• Did you forget to make a function call?

Great feature however! 🎉

[alex-okrushko]

@erhise
Thanks, adjusted for the better wording.

[timdeschryver]

Smart Alex 👍!