feat(effect): catch action creators being returned in effect without () #2536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
In #2306 we are catching actionCreators that are not called in
store.dispatch(actionCreatorNotCalled)
at compile time, however it was still possible to map toActionCreator
in the effects by accident: https://twitter.com/DeborahKurata/status/1263612553067819008What is the current behavior?
We are catching at runtime, which is nice, but we can do better.
Closes #
What is the new behavior?
Catch
ActionCreators
that are not called at compile time:Does this PR introduce a breaking change?
Well... somewhat. I needed to adjust the error message and
throwError
operators (or any other one that returnsnever
) would not be taken any more.Other information