Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityDataModule.forRoot returns a ModuleWithProviders type without a generic type argument. #2356

Closed
debuggerpk opened this issue Feb 7, 2020 · 0 comments · Fixed by #2357 or #2366

Comments

@debuggerpk
Copy link
Contributor

Minimal reproduction of the bug/regression with instructions:

After upgrading to angular 9 with ngrx/data, I get the error

EntityDataModule.forRoot returns a ModuleWithProviders type without a generic type argument.

Digging this up, I landed on this from angular documentation. https://angular.io/guide/deprecations#moduleWithProviders

Currently, the @ngrx/data module code does not support the angular9 style ModuleWithProviders. I will be submitting the PR for this.

Expected behavior:

The code should compile smoothly with angular 9

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):

Angular 9 with NgRx 9 beta.0

Other information:

I would be willing to submit a PR to fix this issue

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant