You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):
ngrx store version: 12.1.0
Other information:
In my project I have several reducer function extracted to a variable and a linter rule demands that I specify the type for them.
If I want to satisfy the linter, the inconsistent readonly usage results non compiling code.
I would be willing to submit a PR to fix this issue
[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
The text was updated successfully, but these errors were encountered:
Minimal reproduction of the bug/regression with instructions:
Here we have readonly modifier before the
ActionCreator[]
:platform/modules/store/src/reducer_creator.ts
Lines 24 to 26 in 7515e36
But here we don't:
platform/modules/store/src/reducer_creator.ts
Lines 105 to 108 in 7515e36
Expected behavior:
Be consistent, use readonly in both places.
Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):
ngrx store version: 12.1.0
Other information:
In my project I have several reducer function extracted to a variable and a linter rule demands that I specify the type for them.
If I want to satisfy the linter, the inconsistent readonly usage results non compiling code.
I would be willing to submit a PR to fix this issue
[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
The text was updated successfully, but these errors were encountered: